Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cluster): Make roles configurable #247

Merged
merged 3 commits into from Apr 20, 2024
Merged

feat(cluster): Make roles configurable #247

merged 3 commits into from Apr 20, 2024

Conversation

gpothier
Copy link
Contributor

@gpothier gpothier commented Apr 4, 2024

This makes it possible to configure roles using the chart by adding an array in cluster.roles in values.yaml. The content of the array are taken as is and used as .spec.managed.roles.

This is a follow up to PR #226, which ended up with conflicts, so I started a new one.

In this new PR I signed off my changes, and I ran make schema docs.

The rationale for adding the with inside instead of outside managed: in cluster.yaml is that in case it is needed at some point to bring other things into managed, we would have to put an if with several conditions outside, and several ifs inside in order to avoid the empty element. I did try the chart without specifying roles to check if the empty managed was a problem, and there was no problem.

Closes #201

@gpothier
Make roles configurable
70bd926 
Signed-off-by: Guillaume Pothier <gpothier@gmail.com>
@gpothier
Update README (through make schema docs)
54764b6 
Note: I manually removed a footer that said something like "autogenerated by...", as it is not in the original version. I don't know why my version of helm-docs added it
Signed-off-by: Guillaume Pothier <gpothier@gmail.com>
@gpothier gpothier mentioned this pull request Apr 4, 2024
Closed
@itay-grudev
Copy link
Collaborator

itay-grudev commented Apr 8, 2024 •
edited

I'm sorry for the late response. Just one comment. Otherwise looks good.

@gpothier gpothier mentioned this pull request Apr 19, 2024
Open
2 tasks
@itay-grudev itay-grudev merged commit 2728793 into cloudnative-pg:main Apr 20, 2024
4 checks passed
truecharts-admin added a commit to truecharts/charts that referenced this pull request Apr 25, 2024
@truecharts-admin
chore(deps): update helm chart cloudnative-pg to 0.21.0 by renovate (#…
ad961c8 
…21335)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cloudnative-pg](https://cloudnative-pg.io)
([source](https://togithub.com/cloudnative-pg/charts)) | minor |
`0.20.2` -> `0.21.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>cloudnative-pg/charts (cloudnative-pg)</summary>

###
[`v0.21.0`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.0)

[Compare
Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.20.2...cloudnative-pg-v0.21.0)

CloudNativePG Operator Helm Chart

#### What's Changed

- feat(cluster): Make roles configurable by
[@&#8203;gpothier](https://togithub.com/gpothier) in
[cloudnative-pg/charts#247
- chore(deps): update actions/checkout action to v4.1.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[cloudnative-pg/charts#260
- chore(deps): update helm/kind-action action to v1.10.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[cloudnative-pg/charts#261
- Release cloudnative-pg-v0.21.0 by
[@&#8203;github-actions](https://togithub.com/github-actions) in
[cloudnative-pg/charts#266

#### New Contributors

- [@&#8203;gpothier](https://togithub.com/gpothier) made their first
contribution in
[cloudnative-pg/charts#247

**Full Changelog**:
cloudnative-pg/charts@cluster-v0.0.8...cloudnative-pg-v0.21.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMyMy4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9oZWxtL2dlbmVyYWwvbWlub3IiXX0=-->
nrdufour pushed a commit to nrdufour/home-ops that referenced this pull request Apr 25, 2024
@nrdufour
chore(deps): update helm release cloudnative-pg to v0.21.0 (#457)
910e2b3 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cloudnative-pg](https://cloudnative-pg.io) ([source](https://github.com/cloudnative-pg/charts)) | minor | `0.20.2` -> `0.21.0` |

---

### Release Notes

<details>
<summary>cloudnative-pg/charts (cloudnative-pg)</summary>

### [`v0.21.0`](https://github.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.0)

[Compare Source](cloudnative-pg/charts@cloudnative-pg-v0.20.2...cloudnative-pg-v0.21.0)

CloudNativePG Operator Helm Chart

#### What's Changed

-   feat(cluster): Make roles configurable by [@&#8203;gpothier](https://github.com/gpothier) in cloudnative-pg/charts#247
-   chore(deps): update actions/checkout action to v4.1.3 by [@&#8203;renovate](https://github.com/renovate) in cloudnative-pg/charts#260
-   chore(deps): update helm/kind-action action to v1.10.0 by [@&#8203;renovate](https://github.com/renovate) in cloudnative-pg/charts#261
-   Release cloudnative-pg-v0.21.0 by [@&#8203;github-actions](https://github.com/github-actions) in cloudnative-pg/charts#266

#### New Contributors

-   [@&#8203;gpothier](https://github.com/gpothier) made their first contribution in cloudnative-pg/charts#247

**Full Changelog**: cloudnative-pg/charts@cluster-v0.0.8...cloudnative-pg-v0.21.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjIuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://git.internal/nrdufour/home-ops/pulls/457
Co-authored-by: Renovate <renovate@ptinem.casa>
Co-committed-by: Renovate <renovate@ptinem.casa>
szinn pushed a commit to szinn/k8s-homelab that referenced this pull request Apr 27, 2024
@repo-jeeves
feat(helm): update chart cloudnative-pg ( 0.20.2 → 0.21.0 ) (#3557)
72b39e5 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cloudnative-pg](https://cloudnative-pg.io)
([source](https://togithub.com/cloudnative-pg/charts)) | minor |
`0.20.2` -> `0.21.0` |

---

### Release Notes

<details>
<summary>cloudnative-pg/charts (cloudnative-pg)</summary>

###
[`v0.21.0`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.0)

[Compare
Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.20.2...cloudnative-pg-v0.21.0)

CloudNativePG Operator Helm Chart

#### What's Changed

- feat(cluster): Make roles configurable by
[@&#8203;gpothier](https://togithub.com/gpothier) in
[cloudnative-pg/charts#247
- chore(deps): update actions/checkout action to v4.1.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[cloudnative-pg/charts#260
- chore(deps): update helm/kind-action action to v1.10.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[cloudnative-pg/charts#261
- Release cloudnative-pg-v0.21.0 by
[@&#8203;github-actions](https://togithub.com/github-actions) in
[cloudnative-pg/charts#266

#### New Contributors

- [@&#8203;gpothier](https://togithub.com/gpothier) made their first
contribution in
[cloudnative-pg/charts#247

**Full Changelog**:
cloudnative-pg/charts@cluster-v0.0.8...cloudnative-pg-v0.21.0

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
szinn pushed a commit to szinn/k8s-homelab that referenced this pull request Apr 27, 2024
@repo-jeeves
feat(helm): update chart cloudnative-pg ( 0.20.2 → 0.21.0 ) (#3558)
cb72c5b 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cloudnative-pg](https://cloudnative-pg.io)
([source](https://togithub.com/cloudnative-pg/charts)) | minor |
`0.20.2` -> `0.21.0` |

---

### Release Notes

<details>
<summary>cloudnative-pg/charts (cloudnative-pg)</summary>

###
[`v0.21.0`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.0)

[Compare
Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.20.2...cloudnative-pg-v0.21.0)

CloudNativePG Operator Helm Chart

#### What's Changed

- feat(cluster): Make roles configurable by
[@&#8203;gpothier](https://togithub.com/gpothier) in
[cloudnative-pg/charts#247
- chore(deps): update actions/checkout action to v4.1.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[cloudnative-pg/charts#260
- chore(deps): update helm/kind-action action to v1.10.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[cloudnative-pg/charts#261
- Release cloudnative-pg-v0.21.0 by
[@&#8203;github-actions](https://togithub.com/github-actions) in
[cloudnative-pg/charts#266

#### New Contributors

- [@&#8203;gpothier](https://togithub.com/gpothier) made their first
contribution in
[cloudnative-pg/charts#247

**Full Changelog**:
cloudnative-pg/charts@cluster-v0.0.8...cloudnative-pg-v0.21.0

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
spiceratops added a commit to spiceratops/k8s-gitops that referenced this pull request Apr 27, 2024
@spiceratops
feat(helm): update chart cloudnative-pg to 0.21.1 (#715)
e45421e 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cloudnative-pg](https://cloudnative-pg.io)
([source](https://togithub.com/cloudnative-pg/charts)) | minor |
`0.20.2` -> `0.21.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>cloudnative-pg/charts (cloudnative-pg)</summary>

###
[`v0.21.1`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.1)

[Compare
Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.21.0...cloudnative-pg-v0.21.1)

CloudNativePG Operator Helm Chart

#### What's Changed

- fix: Bump chart dependency grafana-dashboards to version 0.0.2 by
[@&#8203;dexter136](https://togithub.com/dexter136) in
[cloudnative-pg/charts#270

#### New Contributors

- [@&#8203;dexter136](https://togithub.com/dexter136) made their first
contribution in
[cloudnative-pg/charts#270

**Full Changelog**:
cloudnative-pg/charts@cloudnative-pg-v0.21.0...cloudnative-pg-v0.21.1

###
[`v0.21.0`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.0)

[Compare
Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.20.2...cloudnative-pg-v0.21.0)

CloudNativePG Operator Helm Chart

#### What's Changed

- feat(cluster): Make roles configurable by
[@&#8203;gpothier](https://togithub.com/gpothier) in
[cloudnative-pg/charts#247
- chore(deps): update actions/checkout action to v4.1.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[cloudnative-pg/charts#260
- chore(deps): update helm/kind-action action to v1.10.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[cloudnative-pg/charts#261
- Release cloudnative-pg-v0.21.0 by
[@&#8203;github-actions](https://togithub.com/github-actions) in
[cloudnative-pg/charts#266

#### New Contributors

- [@&#8203;gpothier](https://togithub.com/gpothier) made their first
contribution in
[cloudnative-pg/charts#247

**Full Changelog**:
cloudnative-pg/charts@cluster-v0.0.8...cloudnative-pg-v0.21.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMyNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
coolguy1771 pushed a commit to coolguy1771/home-ops that referenced this pull request Apr 29, 2024
@lumiere-bot
feat(helm): update cloudnative-pg ( 0.20.2 → 0.21.1 ) (#4593)
a884fc0 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cloudnative-pg](https://cloudnative-pg.io)
([source](https://togithub.com/cloudnative-pg/charts)) | minor |
`0.20.2` -> `0.21.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>cloudnative-pg/charts (cloudnative-pg)</summary>

###
[`v0.21.1`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.1)

[Compare
Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.21.0...cloudnative-pg-v0.21.1)

CloudNativePG Operator Helm Chart

#### What's Changed

- fix: Bump chart dependency grafana-dashboards to version 0.0.2 by
[@&#8203;dexter136](https://togithub.com/dexter136) in
[cloudnative-pg/charts#270

#### New Contributors

- [@&#8203;dexter136](https://togithub.com/dexter136) made their first
contribution in
[cloudnative-pg/charts#270

**Full Changelog**:
cloudnative-pg/charts@cloudnative-pg-v0.21.0...cloudnative-pg-v0.21.1

###
[`v0.21.0`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.0)

[Compare
Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.20.2...cloudnative-pg-v0.21.0)

CloudNativePG Operator Helm Chart

#### What's Changed

- feat(cluster): Make roles configurable by
[@&#8203;gpothier](https://togithub.com/gpothier) in
[cloudnative-pg/charts#247
- chore(deps): update actions/checkout action to v4.1.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[cloudnative-pg/charts#260
- chore(deps): update helm/kind-action action to v1.10.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[cloudnative-pg/charts#261
- Release cloudnative-pg-v0.21.0 by
[@&#8203;github-actions](https://togithub.com/github-actions) in
[cloudnative-pg/charts#266

#### New Contributors

- [@&#8203;gpothier](https://togithub.com/gpothier) made their first
contribution in
[cloudnative-pg/charts#247

**Full Changelog**:
cloudnative-pg/charts@cluster-v0.0.8...cloudnative-pg-v0.21.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMyNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itay-grudev itay-grudev itay-grudev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for declarative role management
2 participants
@gpothier @itay-grudev