Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
murali-reddy authored and aauren committed Oct 2, 2020
1 parent 7904b7c commit 92b914e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion docs/user-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ graceful termination works in such a way that when kube-router receives a delete

## MTU

The maximum transmission unit (MTU) determines the largest packet size that can be transmitted through your network. MTU for the pod interfaces should be set appropriately to prevent fragmentation and packet drops thereby achieving maximum performance. If you set `auto-mtu` to true kube-router will determine right MTU for both `kube-bridge` and pod interfaces. If you set `auto-mtu` to false kube-router will not attempt to configure MTU. However you can choose the right MTU and set in the `cni-conf.json` section of the `10-kuberouter.conflist` in the kube-router [daemonsets](../daemonset/). For e.g.
The maximum transmission unit (MTU) determines the largest packet size that can be transmitted through your network. MTU for the pod interfaces should be set appropriately to prevent fragmentation and packet drops thereby achieving maximum performance. If `auto-mtu` is set to true (`auto-mtu` is set to true by default as of kube-router 1.1), kube-router will determine right MTU for both `kube-bridge` and pod interfaces. If you set `auto-mtu` to false kube-router will not attempt to configure MTU. However you can choose the right MTU and set in the `cni-conf.json` section of the `10-kuberouter.conflist` in the kube-router [daemonsets](../daemonset/). For e.g.

```
cni-conf.json: |
Expand All @@ -334,6 +334,8 @@ The maximum transmission unit (MTU) determines the largest packet size that can
}
```

If you set MTU yourself via the CNI config, you'll also need to set MTU of `kube-bridge` manually to the right value to avoid packet fragmentation in case of existing nodes on which `kube-bridge` is already created. On node reboot or in case of new nodes joining the cluster both the pod's interface and `kube-bridge` will be setup with specified MTU value.

## BGP configuration

[Configuring BGP Peers](bgp.md)
Expand Down
2 changes: 1 addition & 1 deletion pkg/controllers/routing/network_routes_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ func (nrc *NetworkRoutingController) updateCNIConfig() {
if nrc.autoMTU {
err = nrc.autoConfigureMTU()
if err != nil {
glog.Fatalf("Failed to auto-configure MTU: %s", err.Error())
glog.Errorf("Failed to auto-configure MTU due to: %s", err.Error())
}
}
}
Expand Down

0 comments on commit 92b914e

Please sign in to comment.