Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs incorrect? #1546

Closed
aceeric opened this issue Sep 30, 2023 · 0 comments · Fixed by #1560
Closed

Docs incorrect? #1546

aceeric opened this issue Sep 30, 2023 · 0 comments · Fixed by #1560
Labels

Comments

@aceeric
Copy link

aceeric commented Sep 30, 2023

What happened?
This document: https://github.com/cloudnativelabs/kube-router/blob/master/docs/generic.md says:

Ensure each Kubelet is configured with the following options:
--network-plugin=cni
--cni-conf-dir=/etc/cni/net.d

These parameters are not supported in Kubelet 1.28.1, and, I can't find them in the config file ref here.

What did you expect to happen?
Is the documentation simply incorrect?

How can we reproduce the behavior you experienced?
kubelet --help

**Screenshots / Architecture Diagrams / Network Topologies **
n/a

** System Information (please complete the following information):**

  • Kube-Router Version 1.6.0
  • Kube-Router Parameters: n/a
  • Kubernetes Version 1.28.1
  • Cloud Type: n/a
  • Kubernetes Deployment Type: n/a
  • Kube-Router Deployment Type: n/a
  • Cluster Size: n/a
@aceeric aceeric added the bug label Sep 30, 2023
aauren added a commit that referenced this issue Oct 17, 2023
aauren added a commit that referenced this issue Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant