Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nsc conntrack fix #305

Merged
merged 3 commits into from
Feb 13, 2018
Merged

Nsc conntrack fix #305

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c94484c
added conntrack exit handling logic
roffe Feb 13, 2018
828aaa1
fixed regex
roffe Feb 13, 2018
8b2f317
regex fix again
roffe Feb 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/controllers/network_services_controller.go
View file
Open in desktop
Expand Up @@ -10,6 +10,7 @@ import (
"os"
"os/exec"
"reflect"
"regexp"
"runtime"
"strconv"
"strings"
Expand Down Expand Up @@ -295,6 +296,10 @@ type externalIPService struct {
func (nsc *NetworkServicesController) syncIpvsServices(serviceInfoMap serviceInfoMap, endpointsInfoMap endpointsInfoMap) error {

var ipvsSvcs []*ipvs.Service

// Conntrack exits with non zero exit code when exiting if 0 flow entries have been deleted, use regex to check output and don't Error when matching
re := regexp.MustCompile("([[:space:]]0 flow entries have been deleted.)")

start := time.Now()

defer func() {
Expand Down Expand Up @@ -615,9 +620,11 @@ func (nsc *NetworkServicesController) syncIpvsServices(serviceInfoMap serviceInf

// flush conntrack when endpoint for a UDP service changes
if ipvsSvc.Protocol == syscall.IPPROTO_UDP {
_, err := exec.Command("conntrack", "-D", "--orig-dst", dst.Address.String(), "-p", "udp", "--dport", strconv.Itoa(int(dst.Port))).Output()
out, err := exec.Command("conntrack", "-D", "--orig-dst", dst.Address.String(), "-p", "udp", "--dport", strconv.Itoa(int(dst.Port))).CombinedOutput()
if err != nil {
glog.Error("Failed to delete conntrack entry for endpoint: " + dst.Address.String() + ":" + strconv.Itoa(int(dst.Port)) + " due to " + err.Error())
if matched := re.MatchString(string(out)); !matched {
glog.Error("Failed to delete conntrack entry for endpoint: " + dst.Address.String() + ":" + strconv.Itoa(int(dst.Port)) + " due to " + err.Error())
}
}
glog.V(1).Infof("Deleted conntrack entry for endpoint: " + dst.Address.String() + ":" + strconv.Itoa(int(dst.Port)))
}
Expand Down