Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unified function to set sysctl values #580

Merged
merged 9 commits into from
Nov 22, 2018
Merged

unified function to set sysctl values #580

merged 9 commits into from
Nov 22, 2018

Conversation

roffe
Copy link
Collaborator

@roffe roffe commented Nov 21, 2018

@roffe
Copy link
Collaborator Author

roffe commented Nov 21, 2018

solves #561

pkg/utils/sysctl.go Outdated Show resolved Hide resolved
pkg/utils/sysctl.go Outdated Show resolved Hide resolved
@roffe
Copy link
Collaborator Author

roffe commented Nov 22, 2018

@andrewsykim is this in line with what you was thinking?

@andrewsykim
Copy link
Collaborator

andrewsykim commented Nov 22, 2018

Was just thinking we just create specific variables for those cases, something like (but not exactly):

var SysctlNotFoundErr := errors.New("sysctl not found")
...
...

But I'm realizing now that in Kubernetes core, they just ignore the error 🤷‍♂️

@ticpu
Copy link
Contributor

ticpu commented Apr 11, 2019

I don't know why no one seems to be affected by this, but since arp_ignore is set to 1, all our externalIPs stopped working until we echo 0 > arp_ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants