Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/bgp.md: change example to use printf #594

Conversation

aauren
Copy link
Collaborator

@aauren aauren commented Dec 6, 2018

Using echo places a new-line character at the end of the base64 generated string which will cause the peering to fail for most use-cases as it is unlikely to be present in the configuration of the other peer.

Using echo places a new-line character at the end of the base64
generated string which will cause peering to fail for most use-cases as
it is unlikely to be present in the configuration of the other peer.
@roffe roffe merged commit 0cdaa43 into cloudnativelabs:master Dec 7, 2018
@roffe
Copy link
Collaborator

roffe commented Dec 7, 2018

Hi @aauren echo -n has the same effect but printf works as well 👍

@aauren
Copy link
Collaborator Author

aauren commented Dec 7, 2018

@roffe Thanks for the quick merge! Yeah, I figured printf was a bit safer as echo -n isn't posix compliant and may not work on all systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants