Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the ipAddrAdd performance #965

Closed
wants to merge 1 commit into from
Closed

Improve the ipAddrAdd performance #965

wants to merge 1 commit into from

Commits on Sep 12, 2020

  1. Improve the ipAddrAdd performance 

    This commit removes the `Exec("ip", "route", "replace")` call from `ipAddrAdd`. When `setupClusterIPServices` calls `ipAddrAdd` in a loop, `Exec()` gets executed multiple times and becomes a hot path.

Instead of these looped `Exec()` calls, this method adds a single `Exec("ip", "route", "replace")` call that sets up routing based on the cluster CIDR. This was suggested in cloudnativelabs#965 (comment)
    @iamakulov
    iamakulov committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    c1ff9f9 View commit details
    Browse the repository at this point in the history