Add Support for Reading Peer Passwords via a File #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is passing Travis CI here: https://travis-ci.org/github/cloudnativelabs/kube-router/builds/724682755 |
Syntax of the file is the same as for --peer-router-passwords, that is, a comma separated list of base64 encoded passwords. Passwords specified with --peer-router-passwords have precedence over passwords read from peer-router-passwords-file.
aauren
force-pushed
the
use-peer-pw-from-file
branch
from
5803a1b
to
aaa703a
Compare
|
Rebased on current master. This should be good for review and merge. |
mrueg
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to the PR previously submitted by @jraby in #800, it just needed some rebasing (since the options.go file has changed significantly since he previously submitted) and some extra linting.
This is based on #982 and is meant to be merged after that is merged into the master branch. I've verified that it builds and that all unit tests are currently passing. Additionally, I've deployed into a test cluster and verified the password file functionality.
This is the last PR needed to satisfy issue #794