Add LoadBalancer to getExternalIPs #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aauren
requested changes
Oct 1, 2020
There was a problem hiding this comment.
Overall this looks fine to me. You'll need to update the unit tests to make it pass now that external IPs are being added for LoadBalancer service types. I think it's failing at multiple places:
- https://github.com/cloudnativelabs/kube-router/blob/master/pkg/controllers/routing/network_routes_controller_test.go#L293
- https://github.com/cloudnativelabs/kube-router/blob/master/pkg/controllers/routing/network_routes_controller_test.go#L633
- https://github.com/cloudnativelabs/kube-router/blob/master/pkg/controllers/routing/network_routes_controller_test.go#L897
- https://github.com/cloudnativelabs/kube-router/blob/master/pkg/controllers/routing/ecmp_vip_test.go#L117
- https://github.com/cloudnativelabs/kube-router/blob/master/pkg/controllers/routing/ecmp_vip_test.go#L207
- https://github.com/cloudnativelabs/kube-router/blob/master/pkg/controllers/routing/ecmp_vip_test.go#L281
- https://github.com/cloudnativelabs/kube-router/blob/master/pkg/controllers/routing/ecmp_vip_test.go#L292
Running make should allow you to test the unit tests locally on any host that has a working docker daemon.
Have you had a chance to test your changes in a cluster just to double-check that this does what you want?
|
@aauren -- I can confirm the updates enable BGP advertisement of External-IPs on svc type LoadBalancer. |
|
I can also confirm the changes work, I'll try to update the unit tests. Thanks! |
|
@aauren Tests updated, I also remove the comments about |
aauren
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadBalancer was not advertising externalIPs in services, this fixes it.
Fixes: #994