Default value is not cloned deeply as the original object type

[anschm]

The default value is not cloned deeply as the original type e.g. Date or any other object. The copy is made by the following code:

const defaultValues: FormInterface = deepCopy(formGroup.value);

and the deepCopy method is implemented like:

export const deepCopy = (value: T): T => JSON.parse(JSON.stringify(value));

This is not a deepy copy of an object. The object is transformed to an string or JSON. If the form value type is a Date and you pass a new Date() as default value the inner value is a string. Thats not correct. In this case the moste date pickers handles the inner value as a Date object.

We should use deepCopy from lodash or any other library which makes a deep object copy.

[maxime1992]

Sounds fair enough. I think I'd like to default to the current implementation and let people pass a custom deepCopy function to avoid having another dependency but it feels legit for now and I think we could accept a PR where deepCopy is replaced by one coming from lodash (please use lodash-es though).

Feel free to raise a PR

[anschm]

I would, but your project and my fork have different changes because of all other pull requests I created and which are not merged. I fixed this issues on my fork on this branch:
https://github.com/dillybeeze/ngx-sub-form/tree/fix/deep_clone_default_value

If you have any idea how to get only the 3 changes without making a new fork, feel free to tell me.

[anschm]

PR is available #270

[github-actions]

🎉 This issue has been resolved in version 6.0.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀