Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed to clone default value #270

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Conversation

anschm
Copy link
Contributor

@anschm anschm commented Jul 27, 2022

No description provided.

@maxime1992 maxime1992 self-requested a review July 28, 2022 09:24
@maxime1992 maxime1992 added the type: bug/fix This is a bug or at least needs a fix label Jul 28, 2022
@maxime1992
Copy link
Collaborator

@anschm can you please amend your commit to be written as following:

fix: default form value not cloned as original object type

Fixes cloudnc/ngx-sub-form#268

We do follow semantic versioning and release are made automatically by CI. If you don't have a commit following these you won't get a release.

Changes LGTM though so only waiting for this before merging 👍

@anschm
Copy link
Contributor Author

anschm commented Aug 2, 2022

Done

Copy link
Collaborator

@maxime1992 maxime1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that one in the first pass of the review but it's important to make that change

projects/ngx-sub-form/src/lib/helpers.ts Outdated Show resolved Hide resolved
Co-authored-by: Maxime <maxime.robert1992@gmail.com>
Copy link
Contributor Author

@anschm anschm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted to change lodash import to lodash-es

@maxime1992 maxime1992 self-requested a review August 2, 2022 14:41
@maxime1992 maxime1992 merged commit 04a39f5 into cloudnc:master Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🎉 This PR is included in version 6.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type: bug/fix This is a bug or at least needs a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants