-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to angular 15 #287
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
maxime1992
force-pushed
the
feat/upgrade-angular-15
branch
from
December 9, 2022 10:40
f43230a
to
ede3c5b
Compare
maxime1992
changed the title
[draft] feat: upgrade to angular 15
feat: upgrade to angular 15
Dec 9, 2022
BREAKING CHANGE: Angular 15 required This closes #282
maxime1992
force-pushed
the
feat/upgrade-angular-15
branch
from
December 9, 2022 10:52
19004a5
to
8422703
Compare
In v18 of nodejs we need glibc 2.28 which isn't available on ubuntu 18.04 but is later on, see: nodejs/node#42351 (comment)
maxime1992
force-pushed
the
feat/upgrade-angular-15
branch
from
December 9, 2022 14:59
fdbff26
to
dfba21c
Compare
for some reason cypress wait doesn't seem to pick up that the app is ready with serve
maxime1992
force-pushed
the
feat/upgrade-angular-15
branch
from
December 9, 2022 16:06
bd1881b
to
254c212
Compare
… otherwise it gets all interpreted as an `ls` argument https://github.com/cloudnc/ngx-sub-form/actions/runs/3658909405/jobs/6184280275
maxime1992
force-pushed
the
feat/upgrade-angular-15
branch
from
December 9, 2022 16:21
a4e37d0
to
ddda44d
Compare
Closing in favor of #288 so that I can cut pre-releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #282