Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(types): add Betterer rule for strict mode and fix a few issues #41

Merged
merged 1 commit into from
May 21, 2020

Conversation

phenomnomnominal
Copy link
Contributor

Added Betterer and the @betterer/typescript test, with snapshot of current strict mode issues.

You could integrate the betterer command into your build to make sure that it doesn't get worse!

Also fixed a few issues, hopefully didn't break anything 😅

@zakhenry
Copy link
Collaborator

Hey awesome, thanks @phenomnomnominal - I'll take a closer look at this tomorrow morning. Something seems up with the config as codecov bot is supposed to report the coverage change :/

@zakhenry zakhenry self-requested a review May 20, 2020 21:16
@zakhenry
Copy link
Collaborator

@phenomnomnominal is there a way to have the CI enforce Betterer? It seems that it would be nice to have subsequent CI builds fail if the someone make a PR that is making things worse(er)

@zakhenry
Copy link
Collaborator

Verified (locally) that code coverage remains at 100%, merging. I'll fix up codecov separately.

@zakhenry zakhenry merged commit a999e82 into cloudnc:master May 21, 2020
@phenomnomnominal
Copy link
Contributor Author

@phenomnomnominal is there a way to have the CI enforce Betterer? It seems that it would be nice to have subsequent CI builds fail if the someone make a PR that is making things worse(er)

All you need to do is run betterer in your CI build. I couldn't easily see which command was run, but it should be simple! It'll throw exit code 1 if it gets worse, and 0 if it stays the same or gets better(er)

@zakhenry
Copy link
Collaborator

Ah sweet, I'll add that in, thanks!

@zakhenry
Copy link
Collaborator

raised #43 to do just this ^

@zakhenry
Copy link
Collaborator

🎉 This PR is included in version 3.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants