SonarQube: Adapt to SonarCloud's changes

[schnatterer]

Change in SonarCloud for PullRequests in GitHub

if you were relying on the GitHub Plugin, its properties are no longer required and they must be removed your configuration: sonar.analysis.mode, sonar.github.repository, sonar.github.pullRequest,
sonar.github.oauth

The new properties are described here

sonar.pullrequest.base=master
sonar.pullrequest.branch=feature/my-new-feature
sonar.pullrequest.key=5
sonar.pullrequest.provider=GitHub
sonar.pullrequest.github.repository=my-company/my-repo

Does that mean we need to differentiate between SonarQube and SonarCloud now?

Change here
For an example see schnatterer/sonarcloudTest

Also: waitForQualityGateWebhookToBeCalled() should no longer exclude PRs. As they are fully analysed on SonarCloud now (and the PRs are commented via the GitHub/BitBucket integrations of SonarCloud), we can query the QualityGate status, as for normal builds. See
scm-manager.