Implement air-gapped mode for PrometheusStack #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helm does not have any options for changing dependencies. So our only options is to alter the chart. There, we would have two options for hosting the chart: Git or OCI. Unfortunately it seems that using the OCI way in the local GOP is impossible because we would have to use `helm pull --plain-http oci://. .`, which not to be possible in Argo CD. So we stick with what we already did with spring-boot-helm-chart: Use git.
Do not deploy grafana from separate repo. Keeps code simpler and results in fewer differences between air-gapped and normal mode.
schnatterer
force-pushed
the
feature/prom-stack-air-gapped
branch
from
390d84e
to
597c60b
Compare
schnatterer
force-pushed
the
feature/prom-stack-air-gapped
branch
from
e18c4f2
to
69fd4e2
Compare
Refactored HelmClient to avoid further code duplication. Got rid of deprecated method call on the way. The charts are passed in from the outside (Dockerfile or env var). So it makes sense to validate them at runtime before pushing to git. Fail early!
It is much more concrete and avoids confusion about what the param does (as e.g. --remote did in the past). Air-gapped mode will always be a combination of parameters, like --*-image, --registry-*, and others.
com.oracle.svm.core.jdk.UnsupportedFeatureError: Runtime reflection is not supported for public abstract java.util.Iterator java.util.List.iterator()
at org.graalvm.nativeimage.builder/com.oracle.svm.core.util.VMError.unsupportedFeature(VMError.java:89)
at java.base@17.0.5/java.lang.reflect.Method.acquireMethodAccessor(Method.java:71)
at java.base@17.0.5/java.lang.reflect.Method.invoke(Method.java:566)
at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:343)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:328)
at groovy.lang.MetaClassImpl.doInvokeMethod(MetaClassImpl.java:1331)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1086)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1006)
at org.codehaus.groovy.runtime.InvokerHelper.invokePojoMethod(InvokerHelper.java:633)
at org.codehaus.groovy.runtime.InvokerHelper.invokeMethod(InvokerHelper.java:624)
at org.codehaus.groovy.runtime.InvokerHelper.asIterator(InvokerHelper.java:709)
at org.codehaus.groovy.runtime.DefaultGroovyMethods.find(DefaultGroovyMethods.java:4245)
at com.cloudogu.gitops.utils.AirGappedUtils$_localizeChartYaml_closure1.doCall(AirGappedUtils.groovy:113)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see at least the following test cases:
--mirror-repos: Apply twice and make sure that it does not fail the 2nd time (when repo already exists)--mirror-repos: Everything must still work as before, i.e. the KubePromStack chart refers to the source from the internet. No SCMM repo is created for prometheus in 3rd-party-dependenciesmirror-reposandmonitoringare active