ORArray #59
Merged
ORArray #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dvc94ch
reviewed
Oct 20, 2021
wngr
commented
Oct 22, 2021
dvc94ch
reviewed
Oct 22, 2021
dvc94ch
reviewed
Oct 22, 2021
dvc94ch
reviewed
Oct 22, 2021
dvc94ch
reviewed
Oct 22, 2021
Co-authored-by: David Craven <david@craven.ch>
dvc94ch
reviewed
Oct 23, 2021
dvc94ch
reviewed
Oct 23, 2021
dvc94ch
reviewed
Oct 23, 2021
crdt/src/schema.rs
Outdated
| path.next()?.position()?; | ||
| path.next()?.prim_u64()?; | ||
| path.next()?.nonce()?; | ||
| path.next()?.sig()?; |
There was a problem hiding this comment.
Why is there a second signature?
There was a problem hiding this comment.
My thinking was that during a move the actual value itself is untouched. However I'm not sure about the implications.
What do you think?
There was a problem hiding this comment.
Not sure how it works yet exactly. I'll play around with it once it's merged. Is the signature being verified somewhere?
There was a problem hiding this comment.
No it's not. Where's that done for the other stuff?
Will finish my tests and merge this evening.
There was a problem hiding this comment.
So I guess it makes more sense in this case to overwrite the peer and signature fields when moving.
dvc94ch
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that's the fourth iteration now.
TODO:
Fractionsorting in path, seeFractionsorts incorrectly inside path #72Cursor