-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORArray #59
ORArray #59
Conversation
Co-authored-by: David Craven <david@craven.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!
crdt/src/schema.rs
Outdated
path.next()?.position()?; | ||
path.next()?.prim_u64()?; | ||
path.next()?.nonce()?; | ||
path.next()?.sig()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a second signature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking was that during a move the actual value itself is untouched. However I'm not sure about the implications.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how it works yet exactly. I'll play around with it once it's merged. Is the signature being verified somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's not. Where's that done for the other stuff?
Will finish my tests and merge this evening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I guess it makes more sense in this case to overwrite the peer and signature fields when moving.
I think that's the fourth iteration now.
TODO:
Fraction
sorting in path, seeFraction
sorts incorrectly inside path #72Cursor