Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm-aws-profile-pattern option #25

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Fix helm-aws-profile-pattern option #25

merged 1 commit into from
Feb 23, 2021

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Feb 23, 2021

what

  • Fix helm-aws-profile-pattern option

why

  • Helm/helmfile/kubeconfig AWS profiles use gbl environment in their names (since IAM roles are global)
  • Replacing {environment} with the environment values from the YAML stack configs does not work when running atmos helmfile ... commands for the environments other than gbl

@aknysh aknysh requested review from a team as code owners February 23, 2021 04:49
@aknysh aknysh self-assigned this Feb 23, 2021
@aknysh aknysh merged commit fc85d82 into master Feb 23, 2021
@aknysh aknysh deleted the update-defaults branch February 23, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants