Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't copy unix sockets in atmos describe affected command #640

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Don't copy unix sockets in atmos describe affected command #640

merged 3 commits into from
Jun 27, 2024

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Jun 26, 2024 •
edited
Loading

what

  • Don't copy unix sockets when executing atmos describe affected command
  • Fix some links (left over after renaming examples/quick-start to examples/quick-start-advanced)

why

  • Sockets are not regular files, and if someone uses tools like git-fsmonito and executes atmos describe affected command, the following error will be thrown:
open .git/fsmonitor--daemon.ipc: operation not supported on socket

@aknysh aknysh added the patch A minor, backward compatible change label Jun 26, 2024
@aknysh aknysh requested review from osterman and mcalhoun June 26, 2024 17:27
@aknysh aknysh self-assigned this Jun 26, 2024
@aknysh aknysh requested review from a team as code owners June 26, 2024 17:27
@aknysh aknysh requested review from Gowiem and nitrocode June 26, 2024 17:27
mcalhoun
mcalhoun approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aknysh aknysh merged commit 798bdfb into main Jun 27, 2024
23 checks passed
@aknysh aknysh deleted the update-copy-in-describe-affected-1 branch June 27, 2024 16:04
@github-actions GitHub Actions
Copy link

These changes were released in v1.83.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@mcalhoun mcalhoun mcalhoun approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

Assignees

@aknysh aknysh

Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aknysh @osterman @mcalhoun