Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component inheritance chain #84

Merged
merged 12 commits into from
Dec 8, 2021
Merged

Component inheritance chain #84

merged 12 commits into from
Dec 8, 2021

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Dec 8, 2021

what

  • Add component inheritance chain (unlimited levels)
  • Add inheritance section to component outputs
  • Show inheritance chain when executing atmos commands (Inheritance: test/test-component-override-2 -> test/test-component-override -> test/test-component)

why

  • Allow to inherit config from more than one component, e.g. Component A inherits Component B which in turn inherits Component C (each one can override any attributes)
  • Reuse component config
  • DRY config

related

test

atmos terraform plan test/test-component-override-2 -s tenant1-ue2-dev
Command info:
Terraform binary: /usr/local/bin/terraform
Terraform command: plan
Arguments and flags: []
Component: test/test-component-override-2
Base component: test/test-component
Inheritance: test/test-component-override-2 -> test/test-component-override -> test/test-component
Stack: tenant1/ue2/dev
test/test-component-override-2:
  component: test/test-component
  inheritance:
  - test/test-component-override
  - test/test-component

@aknysh aknysh added the patch A minor, backward compatible change label Dec 8, 2021
@aknysh aknysh self-assigned this Dec 8, 2021
@aknysh aknysh requested review from a team as code owners December 8, 2021 03:19
@aknysh aknysh requested a review from milldr December 8, 2021 03:22
@aknysh aknysh merged commit 496be57 into master Dec 8, 2021
@aknysh aknysh deleted the component-inheritance-chain branch December 8, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Component to include Catalog
3 participants