Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-zero exit code sshrc scripts to properly close connection #77

Merged
merged 3 commits into from
Apr 8, 2023
Merged

Fix non-zero exit code sshrc scripts to properly close connection #77

merged 3 commits into from
Apr 8, 2023

Conversation

jonmchan
Copy link
Contributor

@jonmchan jonmchan commented Apr 6, 2023 •
edited
Loading

what

  • Fixed profile.d scripts to only call .sh files (update from alpine - they include a README file that should not be executed)
  • updated tests to be more extensible
  • added sshrc script exit test
  • fixed sshrc non-zero exit code to work properly terminating user session and not allowing access

why

  • SLACK_FATAL_ERRORS environment variable failed to do anything neither any other script with non-zero exit code

references

@jonmchan jonmchan merged commit 03c6be8 into master Apr 8, 2023
@jonmchan jonmchan deleted the fix-fatal-errors branch April 8, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-lobur max-lobur max-lobur approved these changes

@osterman osterman Awaiting requested review from osterman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SLACK_FATAL_ERRORS does not actually do anything in sshrc
2 participants
@jonmchan @max-lobur