[modules/go] re-write go vet target #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use `go too vet $dir` to vet code
osterman
reviewed
Sep 19, 2018
modules/go/Makefile.style
Outdated
| @@ -6,7 +6,7 @@ go/lint: $(GO) go/vet | |||
| ## Vet code | |||
| go/vet: $(GO) | |||
| $(call assert-set,GO) | |||
| find . ! -path "*/vendor/*" ! -path "*/.glide/*" -type f -name '*.go' | xargs $(GO) vet -v | |||
| $(GO) tool vet -v $(CURDIR) | |||
There was a problem hiding this comment.
Will this go recursively? E.g. projects have go code in multiple folders.
There was a problem hiding this comment.
yeap, it recursively descends the directory, vetting each package it finds.
https://golang.org/cmd/vet/#hdr-Using_vet_directly
|
But we need to exclude the vendor folder since we have to control over the formatting of 3rd party code. Will this automatically exclude that? |
|
@osterman hm, you're right. |
osterman
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
use
go too vet $dirto vet codewhy
go vetcommand require:Should fix cloudposse/github-authorized-keys#29