Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate glide in go targets #345

Merged
merged 5 commits into from
Apr 11, 2023
Merged

chore: deprecate glide in go targets #345

merged 5 commits into from
Apr 11, 2023

Conversation

dudymas
Copy link
Contributor

@dudymas dudymas commented Apr 6, 2023

what

  • deprecate glide
  • replace glide targets with go get/mod

why

  • supporting both go mod and glide is tricky

@dudymas dudymas force-pushed the chore/golang/deprecate-glide branch from 02dd7b4 to ff9e591 Compare April 6, 2023 16:47
osterman
osterman reviewed Apr 6, 2023
View reviewed changes
modules/go/Makefile.build Outdated Show resolved Hide resolved
osterman
osterman reviewed Apr 6, 2023
View reviewed changes
modules/go/Makefile.build Outdated Show resolved Hide resolved
@dudymas dudymas marked this pull request as ready for review April 10, 2023 17:43
@dudymas dudymas requested a review from a team as a code owner April 10, 2023 17:43
@dudymas dudymas requested a review from a team as a code owner April 10, 2023 17:53
@dudymas dudymas self-assigned this Apr 10, 2023
@dudymas dudymas merged commit ca08a9f into master Apr 11, 2023
6 of 7 checks passed
@dudymas dudymas deleted the chore/golang/deprecate-glide branch April 11, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman left review comments

@zdmytriv zdmytriv zdmytriv left review comments

@aknysh aknysh aknysh approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

Assignees

@dudymas dudymas

Labels
modules/go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dudymas @osterman @zdmytriv @aknysh @cloudpossebot