Reimplement portal using strictly nginx-ingress #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2018
goruha
approved these changes
Jul 25, 2018
darend
reviewed
Jul 26, 2018
| {{- end }} | ||
| {{ if $value.tls }} | ||
| nginx.ingress.kubernetes.io/secure-backends: "true" | ||
| nginx.ingress.kubernetes.io/server-snippet: "proxy_ssl_verify off;" |
There was a problem hiding this comment.
It would be nice to have verify as its own flag. You may want TLS AND verification of certs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
portalwithouttraefiktype: ExternalNameresource to define service that can traverse namespacesconfig.hostnameFormatwhy
Ingressresource typedashboard-portal) may be advantageous if using ACM certificatestodo
values.yamlwith more examplesreferences
#146
#150