Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator/thumbor] add container probes #173

Merged
merged 1 commit into from Sep 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion incubator/thumbor/Chart.yaml
@@ -1,4 +1,4 @@
apiVersion: v1
description: A Helm chart for Thumbor+RemoteCV thumbnailing service
name: thumbor
version: 0.2.1
version: 0.3.0
7 changes: 6 additions & 1 deletion incubator/thumbor/templates/deployment.yaml
Expand Up @@ -28,7 +28,8 @@ spec:
args:
- "thumbor"
ports:
- containerPort: {{ .Values.service.internalPort }}
- name: http
containerPort: {{ .Values.service.internalPort }}
env:
- name: ENGINE
value: "opencv_engine"
Expand Down Expand Up @@ -86,3 +87,7 @@ spec:
readOnly: false
resources:
{{ toYaml .Values.resources | indent 12 }}
livenessProbe:
{{ toYaml .Values.livenessProbe | indent 10 }}
readinessProbe:
{{ toYaml .Values.readinessProbe | indent 10 }}
21 changes: 20 additions & 1 deletion incubator/thumbor/values.yaml
Expand Up @@ -96,4 +96,23 @@ remotecv:
cpu: 100m
memory: 128Mi


## Configure extra options for liveness and readiness probes
## ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#configure-probes)
livenessProbe:
httpGet:
path: /healthcheck
port: http
# initialDelaySeconds: 120
# periodSeconds: 10
# timeoutSeconds: 5
# failureThreshold: 6
# successThreshold: 1
readinessProbe:
httpGet:
path: /healthcheck
port: http
# initialDelaySeconds: 30
# periodSeconds: 10
# timeoutSeconds: 5
# failureThreshold: 6
# successThreshold: 1