New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator/monochart] Support multiple cronjobs #180
Conversation
{{- if .Values.job -}} | ||
{{- if .Values.job.enabled -}} | ||
{{- $root := . -}} | ||
{{- range $name, $job := .Values.job -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be .Values.jobs
for consistency with the other "plural" types.
## Read more about kube2iam to provide access to s3 https://github.com/jtblin/kube2iam | ||
# iam.amazonaws.com/role: role-arn | ||
labels: {} | ||
args: [] | ||
|
||
cronjob: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be cronjobs
since it's now plural.
@@ -107,43 +107,47 @@ daemonset: | |||
args: [] | |||
|
|||
job: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be jobs
since it's now plural
What
Why
on install\update
andon delete