Footer Formatting #293
Merged
Footer Formatting #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Also we may add some border top in footer. or small shadow at least? What you think @osterman ? |
Good idea. Can you show a couple examples? |
|
Tags should not be under the categories. Maybe we should move them somewhere else on the page? |
|
What do you think about this?
|
|
|
|
I don't like mixing the concept of the "badge" and overloading it for "tags". In github, badges are one thing. Maybe we should borrow the GitHub UI for this? See tags here....
|
|
Also, we really need some padding below the title and the content. It's so scrunched up |
|
@finnsky rebase |
finnsky
force-pushed
the
footer-fixes-275
branch
from
a95936d
to
173a3c6
Compare
|
|
osterman
approved these changes
Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why