Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typos in docs #584

Closed

Conversation

whyevenquestion1t
Copy link

what

  • Fixed typos in documentation, put dots where they need to be.

why

  • Improves readability and removes distraction.

references

  • Also I am getting familiar with the eco-system and the process of contributing itself.

osterman
osterman previously approved these changes May 17, 2023

* Geodesic bundles most of these tools as part of the geodesic base image
* Geodesic bundles most of these tools as part of the geodesic base image:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like there should be a : here as this is an item in a list.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! I missed it. Everything else seems fine, should I be closing the pull request now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this colon and merge. The rest of the diff make sense to me.

@osterman osterman dismissed their stale review May 17, 2023 22:58

Missed typo

max-lobur
max-lobur previously approved these changes Jul 3, 2023

* Geodesic bundles most of these tools as part of the geodesic base image
* Geodesic bundles most of these tools as part of the geodesic base image:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this colon and merge. The rest of the diff make sense to me.

@osterman
Copy link
Member

@whyevenquestion1t are you able to make the edits?

@whyevenquestion1t
Copy link
Author

@whyevenquestion1t are you able to make the edits?

@osterman yes, I'm on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants