Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aliases] Do not replace existing aliases #499

Merged
merged 11 commits into from Jul 13, 2019
Merged

[aliases] Do not replace existing aliases #499

merged 11 commits into from Jul 13, 2019

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented Jul 12, 2019

what

  1. [aliases] Do not overwrite existing commands with our default aliases and functions
  2. [codefresh] Add some helper functions to be used with Codefresh CI/CD pipeline
  3. [tfenv] Set a default TFENV_BLACKLIST if the variable is not already one set
  4. [docker] Tag docker images with short commit tags as well as long ones

why

  1. If a user has customized Geodesic in a way that conflicts with our defaults, let the user's customization win. Better user experience.
  2. Move toward using Geodesic rather than Build Harness inside CI/CD pipelines.
  3. Prevent secrets in the environment from leaking into Terraform.
  4. Short tags are easier for humans to deal with, and are more visible in the GitHub UI.

@Nuru Nuru requested a review from osterman July 12, 2019 23:19
@Nuru Nuru requested a review from aknysh July 13, 2019 00:06
@@ -0,0 +1,17 @@
#!/bin/bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be generalized to config-directory and take an argument which is the project (e.g Helmfile)

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced with conf-directory helmfiles

@Nuru Nuru requested a review from osterman July 13, 2019 23:28
@Nuru Nuru merged commit 2cc986d into master Jul 13, 2019
@Nuru Nuru deleted the noclobber branch July 16, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants