Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handling of user+group creation on Debian #900

Closed
wants to merge 1 commit into from
Closed

fix: handling of user+group creation on Debian #900

wants to merge 1 commit into from

Conversation

major0
Copy link

@major0 major0 commented Jan 10, 2024

The current handling of user, uid, and gid are incomplete and subject to failure.

  • The adduser/addgroup commands on Debian based systems are much more pedantic than other platforms and will error out on some surprising conditions.
  • We want to support situations in which the username or groupname is pulled from systems which support characters such a spaces in the names which are prohibited in the POSIX passwd/group files.
  • We need to handle the condition in which the group the user belongs to does not already exist.

what

  • Pass the groupname via the GROUP env variable in the wrapper script
  • Create the group if it does not already exist
  • Properly create the user on debian based systems

why

Screenshot from 2024-01-10 12-05-57

@major0
fix: handling of user+group creation on Debian
a0420ac 
The adduser/addgroup commands on Debian based systems are much more
pedantic than other platforms and will error out on some surprising
conditions. Further more, we want to support situations in which the
username or groupname is pulled from systems which support characters
such a spaces in the names which are prohibited in the POSIX
passwd/group files.
@major0 major0 requested a review from a team as a code owner January 10, 2024 23:04
@Nuru Nuru added wip Work in Progress: Not ready for final review or merge do not merge Do not merge this PR, doing so would cause problems labels Jan 11, 2024
@Nuru Nuru mentioned this pull request Jan 12, 2024
Merged
@Nuru Nuru closed this in #901 Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge Do not merge this PR, doing so would cause problems wip Work in Progress: Not ready for final review or merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@major0 @Nuru