Add ghr package #27
Merged
Add ghr package #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Jul 26, 2018
install/Makefile
Outdated
| @@ -3,6 +3,13 @@ OS ?= $(shell uname -s | tr '[:upper:]' '[:lower:']) | |||
| INSTALL_PATH ?= /usr/local/bin | |||
| CURL ?= curl --fail -sSL | |||
| TMP ?= /tmp | |||
| EXTENSION="" | |||
|
|
|||
| ifeq ($(OS),darwin) | |||
There was a problem hiding this comment.
We cannot use a global conditional to map OS to an extension because there's no way to guarantee all projects will use the same convention.
There was a problem hiding this comment.
Instead, use this pattern:
https://github.com/cloudposse/packages/blob/master/install/Makefile#L128-L142
osterman
requested changes
Jul 26, 2018
osterman
approved these changes
Jul 31, 2018
osterman
requested changes
Jul 31, 2018
| ghr-linux: | ||
| $(CURL) -o - https://github.com/tcnksm/ghr/releases/download/v$(GHR_VERSION)/ghr_v$(GHR_VERSION)_linux_$(ARCH).tar.gz | tar --wildcards -zxO */ghr > $(INSTALL_PATH)/ghr | ||
| chmod +x $(INSTALL_PATH)/ghr | ||
|
|
There was a problem hiding this comment.
Missing target to intall ghr
Should be something like:
## Install ghr to easily upload multiple artifacts to GitHub Release
ghr: ghr-$(OS)
@exit 0
osterman
requested changes
Aug 2, 2018
install/Makefile
Outdated
| $(CURL) -o - https://github.com/tcnksm/ghr/releases/download/v$(GHR_VERSION)/ghr_v$(GHR_VERSION)_linux_$(ARCH).tar.gz | tar --wildcards -zxO */ghr > $(INSTALL_PATH)/ghr | ||
| chmod +x $(INSTALL_PATH)/ghr | ||
|
|
||
| ghr: ghr-$(OS) |
osterman
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
ghrwhy
references