Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding SNI cert support #64

Merged
merged 7 commits into from
Nov 28, 2020
Merged

Adding SNI cert support #64

merged 7 commits into from
Nov 28, 2020

Conversation

jamengual
Copy link
Contributor

what

  • Enable SNI support for https listener when https listener is enabled

why

  • many times an alb is reuse for multiple urls and with SNI support we can attach multiple certs to the same listener

references

@jamengual jamengual requested a review from a team as a code owner November 28, 2020 00:42
@jamengual jamengual requested review from Makeshift and RothAndrew and removed request for a team November 28, 2020 00:42
@jamengual
Copy link
Contributor Author

/rebuild-readme

@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/rebuild-readme

@jamengual
Copy link
Contributor Author

/test all

@jamengual jamengual merged commit f65bf47 into master Nov 28, 2020
@jamengual jamengual deleted the multicert_http_listener branch November 28, 2020 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift

@RothAndrew RothAndrew Awaiting requested review from RothAndrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamengual @osterman @actions-bot