Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass module.this.context to cloudposse/lb-s3-bucket/aws #86

Merged
merged 5 commits into from Apr 23, 2021
Merged

Pass module.this.context to cloudposse/lb-s3-bucket/aws #86

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
56e31c5
Pass module.this.context to cloudposse/lb-s3-bucket/aws
jwstric2 Apr 13, 2021
13fcbbb
Remove the existing values name, namespace, stage, environment, delim…
jwstric2 Apr 22, 2021
1b748ef
Merge branch 'master' into bugfix/context_s3_access_bucket
jwstric2 Apr 22, 2021
c265932
Add skips to new bridgecrew checks
jwstric2 Apr 22, 2021
9edb000
Merge branch 'master' into bugfix/context_s3_access_bucket
jamengual Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions main.tf
View file
Open in desktop
Expand Up @@ -57,6 +57,7 @@ module "access_logs" {
noncurrent_version_transition_days = var.noncurrent_version_transition_days
standard_transition_days = var.standard_transition_days
force_destroy = var.alb_access_logs_s3_bucket_force_destroy
context = module.this.context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwstric2 since you added the context argument, can you remove the name, namespace, stage, environment, delimiter, and tags? context will replace all those values so they're not needed. Obviously, let's keep attributes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do, I forgot to ask if those should be removed when opening up this PR.

}

resource "aws_lb" "default" {
Expand Down