Allow var access_logs_enabled = false without having to set a bucket id #87

joe-niland · 2021-04-15T03:42:50Z

what

Set the bucket value in alb access_logs block differently to allow empty values to be set for bucket ids when access logs are disabled

The current implementation generates a Terraform error if access logs are disabled, and bucket id is not set (due to the fact that coalesce() requires at least one non-null, non-empty element

joe-niland · 2021-04-15T03:45:02Z

/test all

joe-niland · 2021-04-15T20:24:18Z

/test all

joe-niland added 2 commits April 15, 2021 12:42

set access_logs bucket differently to allow no values set for bucket ids

e1360f3

Add test for no access logs

7b83cb4

joe-niland requested review from a team as code owners April 15, 2021 03:42

joe-niland requested review from dotCipher and RothAndrew and removed request for a team April 15, 2021 03:42

revert test Makefile change

7bd1d55

jamengual previously approved these changes Apr 15, 2021

View reviewed changes

Remove test for no access logs

860bc3b

joe-niland dismissed jamengual’s stale review via 860bc3b April 15, 2021 20:23

Gowiem approved these changes Apr 15, 2021

View reviewed changes

joe-niland merged commit ab91a3e into cloudposse:master Apr 15, 2021

joe-niland deleted the fix-access-logs-disabled branch April 15, 2021 21:54