Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple rules #43

Merged
merged 3 commits into from
Jun 24, 2022
Merged

Multiple rules #43

merged 3 commits into from
Jun 24, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jun 23, 2022 •
edited

what

why

references

commands

module "backup" {
  source = "git::https://github.com/cloudposse/terraform-aws-backup?ref=hotfix"
}
$ terraform plan
Plan: 2 to add, 0 to change, 0 to destroy.

Changes to Outputs:
  + backup_plan_arn     = (known after apply)
  + backup_plan_version = (known after apply)
  + backup_selection_id = (known after apply)

@nitrocode nitrocode added the patch A minor, backward compatible change label Jun 23, 2022
@nitrocode nitrocode requested review from a team as code owners June 23, 2022 23:58
@nitrocode nitrocode requested review from dylanbannon and SweetOps and removed request for a team June 23, 2022 23:58
@nitrocode
Copy link
Member Author

/test all

Benbentwo
Benbentwo previously approved these changes Jun 24, 2022
View reviewed changes
@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode requested a review from Benbentwo June 24, 2022 02:04
Benbentwo
Benbentwo previously approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@Benbentwo Benbentwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode removed the patch A minor, backward compatible change label Jun 24, 2022
@nitrocode nitrocode changed the title Hotfix Multiple rules Jun 24, 2022
@nitrocode nitrocode requested a review from Benbentwo June 24, 2022 02:26
@nitrocode nitrocode merged commit 589fbb6 into master Jun 24, 2022
@nitrocode nitrocode deleted the hotfix branch June 24, 2022 02:50
@nightspotlight nightspotlight mentioned this pull request Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benbentwo Benbentwo Benbentwo approved these changes

@dylanbannon dylanbannon Awaiting requested review from dylanbannon dylanbannon was automatically assigned from cloudposse/contributors

@SweetOps SweetOps Awaiting requested review from SweetOps SweetOps was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nitrocode @Benbentwo