Cache Behavior fix and user experience enhancements #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates in this PR:
Fix to update "cache_behavior" to "ordered_cache_behavior" to match AWS deprecated terminology here. Functionally this is the same just a rename
Setting of default_root_object to an empty string by default, instead of "index.html". Setting this to index.html will break expected behavior from some CMS frameworks and it's not always entirely obvious where the breakage is occurring. A good example is WordPress - if the default document requested is index.html, WordPress will 404 on the home page. Let the end user decide how to use this.
Exposed the "force_destroy" option of the logs module, used inside this module, to the end user. Otherwise, out-of-the-box this module will create a Cloudfront distribution, but you can't destroy it through any means without first cleaning up the S3 log bucket. This might be desired behavior by some, but at least exposing the option, since we support it in the logs module already, is useful.