upgrade 0.12 #27
Closed
upgrade 0.12 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update terraform-aws-s3-log-storage source to 0.12 compatible cloudposse published upstream version (0.5.0) update terraform-aws-route53-alias source to 0.12 compatible cloudposse published upstream version (0.3.0)
|
I believe this commit finishes this work. I was able to get it to successfully run by fixing 0.12 upgrade bug from wrapping var.custom_error_response around wrapping it in a list. I submitted a PR to the upstream fork: Not sure if it would be easier to just make a new PR, so I did that here: Happy to close it out if you prefer I work through this PR. |
Fixing issue with list(string) for custom_error_response variable
dont wrap var.custom_error_response in a list - 0.12 upgrade fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.