Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to disable logging #45

Merged
merged 1 commit into from Nov 11, 2020
Merged

add option to disable logging #45

merged 1 commit into from Nov 11, 2020

Conversation

mihaiplesa
Copy link
Contributor

@mihaiplesa mihaiplesa commented Nov 11, 2020 •
edited

what

  • added logging_disabled options to disable CloudFront logging to S3

why

  • logging was enabled by default with no easy way of disabling

references

@mihaiplesa mihaiplesa requested review from a team as code owners November 11, 2020 06:34
@joe-niland
Copy link
Sponsor Member

/test all

@joe-niland joe-niland merged commit 00d918b into cloudposse:master Nov 11, 2020
@joe-niland
Copy link
Sponsor Member

Thanks for your contribution @mihaiplesa !

@mihaiplesa mihaiplesa changed the title added option to disable logging add option to disable logging Nov 12, 2020
@mihaiplesa mihaiplesa deleted the mplesa-logging-disable-option branch November 12, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-niland joe-niland joe-niland approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher

@danjbh danjbh Awaiting requested review from danjbh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mihaiplesa @joe-niland