Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom_header variable to send custom headers to origin #47

Merged
merged 1 commit into from
Dec 6, 2020

Conversation

bkero
Copy link
Contributor

@bkero bkero commented Nov 24, 2020

what

  • Adds the ability to specify custom headers that are sent to the origin for requests

why

  • To facilitate the common pattern of only allowing traffic to origins that come form a certain CloudFront CDN, or for other use cases

references

closes #46

@bkero bkero requested review from a team as code owners November 24, 2020 00:15
@bkero bkero requested review from adamcrews and 3h4x November 24, 2020 00:15
@osterman
Copy link
Member

/test all

@mihaiplesa
Copy link
Contributor

Seems to have failed bats with:

ERROR: unsatisfiable constraints:
  json2hcl (missing):
    required by: world[json2hcl]
make: *** [Makefile.alpine:4: deps] Error 1
Error: Process completed with exit code 2.

@mihaiplesa
Copy link
Contributor

@osterman any chance we can retest this?

@joe-niland
Copy link
Sponsor Member

/test bats

@joe-niland joe-niland merged commit b61243e into cloudposse:master Dec 6, 2020
@joe-niland
Copy link
Sponsor Member

@mihaiplesa thanks for your contribution!

@mihaiplesa
Copy link
Contributor

Credit goes to @bkero here at Brave. Thanks for helping on a Sunday!

@joe-niland
Copy link
Sponsor Member

@mihaiplesa my mistake!
Thanks for the PR @bkero !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for sending custom headers to origin
4 participants