Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Origin Request Policy for cache behaviours #60

Merged
merged 3 commits into from Mar 31, 2021
Merged

Adding Origin Request Policy for cache behaviours #60

merged 3 commits into from Mar 31, 2021

Conversation

justnom
Copy link
Contributor

@justnom justnom commented Mar 29, 2021

what

  • Adds the Origin Request Policy attribute to the CloudFront distribution cache behaviours
  • Nullifies any cache forwarded values if non-legacy cache behaviours are set. Taken from @dmattia PR.

why

  • Allow the user to provide a custom Origin Request Policy for the underlying CloudFront distribution

references

@justnom justnom requested review from a team as code owners March 29, 2021 20:20
@jamengual
Copy link

/test all

jamengual
jamengual previously approved these changes Mar 31, 2021
View reviewed changes
@jamengual
Copy link

@justnom please check the tests.


TestExamplesComplete 2021-03-31T03:55:28Z command.go:121: Error: error creating CloudFront Distribution: InvalidArgument: The parameter ForwardedValues is required.
TestExamplesComplete 2021-03-31T03:55:28Z command.go:121: 	status code: 400, request id: 670f4324-91f8-47e1-a9fc-84aaf94bb387

@justnom
Copy link
Contributor Author

justnom commented Mar 31, 2021

/test all

1 similar comment
@jamengual
Copy link

/test all

@jamengual jamengual merged commit e0eb2ef into cloudposse:master Mar 31, 2021
@justnom justnom deleted the add-origin-request-policy-id branch March 31, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justnom @jamengual @cloudpossebot