Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates SNS_Topic Name #37

Merged
merged 4 commits into from
Jul 28, 2021
Merged

Updates SNS_Topic Name #37

merged 4 commits into from
Jul 28, 2021

Conversation

Benbentwo
Copy link
Member

@Benbentwo Benbentwo commented Jul 28, 2021 •
edited
Loading

what

  • Updates sns_topic name
    From CloudTrailBreach-threshold-alerts to ${namespace}-${env}-${stage}-cloudwatch-cloudtrail-breach

why

  • follow naming convention

@Benbentwo Benbentwo added the patch A minor, backward compatible change label Jul 28, 2021
@Benbentwo Benbentwo requested review from a team as code owners July 28, 2021 17:45
@Benbentwo Benbentwo requested a review from a team as a code owner July 28, 2021 17:46
@Benbentwo Benbentwo requested review from florian0410 and SweetOps and removed request for a team July 28, 2021 17:46
osterman
osterman previously approved these changes Jul 28, 2021
View reviewed changes
nitrocode
nitrocode reviewed Jul 28, 2021
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@nitrocode
Copy link
Member

/test all

@Benbentwo Benbentwo merged commit 6275e3f into master Jul 28, 2021
@Benbentwo Benbentwo deleted the update-name branch July 28, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@osterman osterman osterman left review comments

@florian0410 florian0410 Awaiting requested review from florian0410

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Benbentwo @nitrocode @osterman @cloudpossebot