Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add input exclude_management_event_sources closes #54 #60

Closed

Conversation

mattjamesaus
Copy link

what

  • Add support for the exclude_management_event_sources parameter

why

references

closes #54

@mattjamesaus mattjamesaus requested review from a team as code owners April 26, 2023 00:48
@mattjamesaus mattjamesaus changed the title add exclude_management_event_sources closes #54 add input exclude_management_event_sources closes #54 Apr 27, 2023
@riabuz
Copy link

riabuz commented Aug 4, 2023

can this please get reviewed and merged?

@joe-niland joe-niland added the minor New features that do not break anything label Aug 4, 2023
@joe-niland
Copy link
Sponsor Member

Hi @mattjamesaus, thanks for this.

Just a couple of linting issues and also doc updates.

Could you please run:

terraform fmt
make
make readme
make github/init

... and commit the results?

@riabuz
Copy link

riabuz commented Sep 6, 2023

@mattjamesaus could you please make the formatting changes and get this merged? thank you 🙏

@mattjamesaus
Copy link
Author

@riabuz sorry this took so long formatting changed

@mattjamesaus
Copy link
Author

@riabuz not sure if this is still something we want open or not? Just doing a clean up of my PRs and noticed this was still un-merged

@joe-niland joe-niland added minor New features that do not break anything and removed minor New features that do not break anything labels Feb 3, 2024
@joe-niland
Copy link
Sponsor Member

Hey @mattjamesaus thanks for this. Could you please also run the other make commands and commit?

@hans-d
Copy link

hans-d commented Mar 2, 2024

Hey @mattjamesaus thanks for this. Could you please also run the other make commands and commit?

Bump

@hans-d hans-d added the stale This PR has gone stale label Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

Copy link

mergify bot commented Mar 9, 2024

Thanks @mattjamesaus for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot removed the stale This PR has gone stale label Mar 15, 2024
@gagarinfan
Copy link

Hi! Any chances for merging this PR soon?
@mattjamesaus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use exclude_management_event_sources in event_selector
7 participants