Add secondary sources #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add secondary sources
cfir
requested review from
jamengual and
SweetOps
and removed request for
a team
SweetOps
previously requested changes
Jan 21, 2021
| @@ -280,6 +280,23 @@ resource "aws_codebuild_project" "default" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "secondary_sources"{ | |||
| iterator = secondary_source | |||
There was a problem hiding this comment.
remove pls iterator for consistency with other modules
| @@ -280,6 +280,23 @@ resource "aws_codebuild_project" "default" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "secondary_sources"{ | |||
| iterator = secondary_source | |||
| for_each = length(var.secondary_sources) > 0 ? var.secondary_sources : [] | |||
There was a problem hiding this comment.
this condition isn't required
| iterator = secondary_source | ||
| for_each = length(var.secondary_sources) > 0 ? var.secondary_sources : [] | ||
| content { | ||
| git_clone_depth = secondary_source.value.git_clone_depth |
There was a problem hiding this comment.
need to add fallback to null for non-required vars (see
terraform-aws-codebuild/main.tf
Line 324 in 974c9d5
|
This pull request is now in conflict. Could you fix it @cfir? 🙏 |
mergify
bot
dismissed
SweetOps’s stale review
This Pull Request has been updated, so we're dismissing all reviews.
This reverts commit 55d0d2b.
|
Hey all, what needs to be done to get this integraded ? We need the same feature so if I can help ... |
This was referenced Mar 15, 2021
|
This feature has been added to the module in #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
I am adding dynamic object to support secindary sources
why
You are not supporting it right now and we need it.