Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
31 changed files
with
306 additions
and
229 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
## PR [#814](https://github.com/cloudposse/terraform-aws-components/pull/814) | ||
|
||
### Possible Breaking Change | ||
|
||
The `module "datadog_integration"` and `module "store_write"` had been changed | ||
in an earlier PR from a module without a `count` | ||
to a module with a `count` of zero or one. This PR changes it back to a module | ||
without a count. If you were using the module with a `count` of zero or one, | ||
applying this new version will cause it be destroyed and recreated. This should only | ||
cause a very brief outage in your Datadog monitoring. | ||
|
||
### New Integration Options | ||
|
||
This PR adds the following new integration options: | ||
|
||
- `cspm_resource_collection_enabled` - Enable Datadog Cloud Security Posture Management scanning of your AWS account. See [announcement](https://www.datadoghq.com/product/cloud-security-management/cloud-security-posture-management/) for details. | ||
- `metrics_collection_enabled` - When enabled, a metric-by-metric crawl of the CloudWatch API pulls data and sends it | ||
to Datadog. New metrics are pulled every ten minutes, on average. | ||
- `resource_collection_enabled` - Some Datadog products leverage information about how your AWS resources ( | ||
such as S3 Buckets, RDS snapshots, and CloudFront distributions) are configured. | ||
When `resource_collection_enabled` is `true`, Datadog collects this information | ||
by making read-only API calls into your AWS account. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
## PR [#814](https://github.com/cloudposse/terraform-aws-components/pull/814) | ||
|
||
### Fix for `enabled = false` or Destroy and Recreate | ||
|
||
Previously, when `enabled = false` was set, the component would not necessarily | ||
function as desired (deleting any existing resources and not creating any new ones). | ||
Also, previously, when deleting the component, there was a race condition where | ||
the log group could be deleted before the lambda function was deleted, causing | ||
the lambda function to trigger automatic recreation of the log group. This | ||
would result in re-creation failing because Terraform would try to create the | ||
log group but it already existed. | ||
|
||
These issues have been fixed in this PR. |
Oops, something went wrong.