Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vpc] update dynamic-subnet module version #1048

Merged
merged 1 commit into from
May 30, 2024

Conversation

mtb-xt
Copy link
Contributor

@mtb-xt mtb-xt commented May 28, 2024

what

Update dynamic-subnets module version to fix issue #1047

why

Version 2.3.0 of dynamic-subnets does not support the new opt-in Melbourne region.

references

This change in utils module adds support for Melbourne (amongst other regions) - cloudposse/terraform-aws-utils#26
And this is the version of dynamic-subnets where it was updated to use the updated utils module. https://github.com/cloudposse/terraform-aws-dynamic-subnets/releases/tag/2.4.0

This PR closes #1047

@mtb-xt mtb-xt requested review from a team as code owners May 28, 2024 05:08
@goruha
Copy link
Member

goruha commented May 29, 2024

These changes were released in v1.451.0.

@mtb-xt
Copy link
Contributor Author

mtb-xt commented May 29, 2024

@mtb-xt Please rebase branch.

It is done

@mtb-xt
Copy link
Contributor Author

mtb-xt commented May 30, 2024

@goruha rebased again

@goruha goruha enabled auto-merge (squash) May 30, 2024 09:33
@goruha goruha disabled auto-merge May 30, 2024 10:30
@goruha goruha enabled auto-merge (squash) May 30, 2024 10:30
@osterman
Copy link
Member

This branch is out-of-date with the base branch

I'm not sure why we are seeing this. This setting is disabled, yet GH is still enforcing it here.

@goruha goruha disabled auto-merge May 30, 2024 15:35
@goruha goruha merged commit d556d73 into cloudposse:main May 30, 2024
5 checks passed
@mtb-xt mtb-xt deleted the ISSUE-1047 branch June 5, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vpc: subnets module does not support Melbourne region
3 participants