Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow IAM users to assume team roles via an optional flag #495

Merged
merged 4 commits into from Sep 21, 2022
Merged

Allow IAM users to assume team roles via an optional flag #495

merged 4 commits into from Sep 21, 2022

Conversation

joe-niland
Copy link
Sponsor Member

@joe-niland joe-niland commented Sep 21, 2022 •
edited by Nuru

NOTE

This feature did not work. The feature was fixed and the flag renamed to iam_users_enabled in PR #507, Release version 1.84.0

what

  • Adds a flag var.deny_all_iam_users which, when disabled, will allow IAM users to assume team roles
  • Specific users can still be denied via var.denied_principal_arns

why

  • The existing functionality denies all IAM users from assuming team roles
  • In legacy/specific situations it would be good to allow this

references

  • None

(PR submitted on behalf of @Gowiem)

@Gowiem
Copy link
Member

Gowiem commented Sep 21, 2022

@joe-niland 👍 You improved upon my original -- Thank you! 👏

@joe-niland joe-niland marked this pull request as ready for review September 21, 2022 01:51
@joe-niland joe-niland requested review from a team as code owners September 21, 2022 01:51
@Nuru Nuru added the minor New features that do not break anything label Sep 21, 2022
@Nuru Nuru merged commit 9a086ff into cloudposse:master Sep 21, 2022
@Gowiem
Copy link
Member

Gowiem commented Sep 21, 2022

Good stuff -- Thanks for the help @Nuru 👍

@joe-niland joe-niland deleted the account-map-allow-iam-users-to-assume-team-role branch September 21, 2022 19:33
@Nuru Nuru mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joe-niland @Gowiem @Nuru @cloudpossebot