Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update and add more basic pre-commit hooks #714

Merged
merged 7 commits into from
Jun 12, 2023
Merged

chore: Update and add more basic pre-commit hooks #714

merged 7 commits into from
Jun 12, 2023

Conversation

MaxymVlasov
Copy link
Contributor

@MaxymVlasov MaxymVlasov commented Jun 8, 2023

what

Fix common issues in the repo

why

It violates our basic checks, which adds a headache to using https://github.com/cloudposse/github-action-atmos-component-updater as is

image

Note: It is much simpler to review PR if hide whitespace changes

@MaxymVlasov MaxymVlasov requested review from a team as code owners June 8, 2023 11:28
@MaxymVlasov MaxymVlasov changed the title Update and add more basic pre-commit hooks chore: Update and add more basic pre-commit hooks Jun 8, 2023
@MaxymVlasov
Copy link
Contributor Author

Failed bats tests are not related to my changes. Someone earlier did not add descriptions to shell scripts.

aknysh
aknysh previously approved these changes Jun 8, 2023
aknysh
aknysh previously approved these changes Jun 9, 2023
@goruha
Copy link
Member

goruha commented Jun 12, 2023

@MaxymVlasov
Thanks for your contribution.

LGTM

@goruha goruha merged commit 01e88f0 into cloudposse:main Jun 12, 2023
2 of 3 checks passed
@MaxymVlasov MaxymVlasov deleted the fix_common_issues branch June 13, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants