-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update and add more basic pre-commit hooks #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxymVlasov
changed the title
Update and add more basic pre-commit hooks
chore: Update and add more basic pre-commit hooks
Jun 8, 2023
Failed bats tests are not related to my changes. Someone earlier did not add descriptions to shell scripts. |
aknysh
reviewed
Jun 8, 2023
aknysh
previously approved these changes
Jun 8, 2023
aknysh
previously approved these changes
Jun 9, 2023
aknysh
approved these changes
Jun 10, 2023
goruha
approved these changes
Jun 12, 2023
@MaxymVlasov LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Fix common issues in the repo
why
It violates our basic checks, which adds a headache to using https://github.com/cloudposse/github-action-atmos-component-updater as is