[eks/argocd] Added ArgoCD notification configuration #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aws-components into argocd-improvments * 'argocd-improvments' of github.com:cloudposse/terraform-aws-components: pre-commit fixes
milldr
reviewed
Sep 1, 2023
milldr
reviewed
Sep 1, 2023
milldr
reviewed
Sep 1, 2023
aknysh
reviewed
Sep 1, 2023
aknysh
reviewed
Sep 1, 2023
aknysh
reviewed
Sep 1, 2023
aknysh
reviewed
Sep 1, 2023
| @@ -1,4 +0,0 @@ | |||
| output "metadata" { | |||
There was a problem hiding this comment.
why removing the outputs?
metadata is OK to output
There was a problem hiding this comment.
Metadata outputs helm values - it is hard to read and can expose secrets
aknysh
reviewed
Sep 1, 2023
| } | ||
|
|
||
| provider "github" { | ||
| base_url = local.github_webhook_enabled ? var.github_base_url : null |
There was a problem hiding this comment.
will it work when enabled = false?
(we need to support enabled = false)
There was a problem hiding this comment.
enabled used in local.github_webhook_enabled
aknysh
reviewed
Sep 1, 2023
aknysh
reviewed
Sep 1, 2023
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
…aws-components into argocd-improvments * 'argocd-improvments' of github.com:cloudposse/terraform-aws-components: pre-commit fixes
…aws-components into argocd-improvments * 'argocd-improvments' of github.com:cloudposse/terraform-aws-components: pre-commit fixes feat: spacelift/worker-pool can fully name and re-use iam role (#849)
aknysh
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why