Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgoCD Slack Notifications #905

Merged
merged 15 commits into from Dec 6, 2023
Merged

ArgoCD Slack Notifications #905

merged 15 commits into from Dec 6, 2023

Conversation

milldr
Copy link
Sponsor Member

@milldr milldr commented Nov 9, 2023 •
edited

what

  • Adding support for Slack notifications
  • The notifictations.tf file has been renamed to notifications.tf
  • Spelling and code clean up

why

  • New feature support: notifying Slack by app integration on sync
  • Correct spelling
  • Satisfy tflint

references

  • n/a

bridgecrew[bot]
bridgecrew bot reviewed Nov 10, 2023
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

modules/argocd-repo/main.tf Show resolved Hide resolved
modules/argocd-repo/main.tf Show resolved Hide resolved
@milldr milldr marked this pull request as ready for review December 6, 2023 18:36
@milldr milldr requested review from a team as code owners December 6, 2023 18:36
milldr
milldr commented Dec 6, 2023
View reviewed changes
modules/eks/argocd/README.md Outdated Show resolved Hide resolved
@milldr milldr merged commit a320627 into main Dec 6, 2023
3 of 4 checks passed
@milldr milldr deleted the argocd-slack-notifications branch December 6, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgecrew bridgecrew[bot] bridgecrew left review comments

@Benbentwo Benbentwo Benbentwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@milldr @Benbentwo