Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spacelift/worker-pool AMI User Data Docker Login #913

Merged
merged 2 commits into from Nov 23, 2023
Merged

fix: spacelift/worker-pool AMI User Data Docker Login #913

merged 2 commits into from Nov 23, 2023

Conversation

milldr
Copy link
Member

@milldr milldr commented Nov 22, 2023 •
edited

what

  • Updated CLI command to log into docker in Spacelift Worker Pool user data

why

  • Spacelift has updated the AWS CLI in their AMIs, creating a breaking change. This is a quote from Spacelift

[...] you have a very good point about this being an unannounced breaking change. we’ll prepare an announcment today, and we’ll try to think about introducing semver into this process. sorry for the inconvenience.

references

@milldr milldr requested review from a team as code owners November 22, 2023 17:19
hans-d
hans-d approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@hans-d hans-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codewise +1

@milldr milldr changed the title spacelift/worker-pool User Data Docker Login Fix spacelift/worker-pool AMI User Data Docker Login Nov 23, 2023
@milldr milldr changed the title Fix spacelift/worker-pool AMI User Data Docker Login fix: spacelift/worker-pool AMI User Data Docker Login Nov 23, 2023
@max-lobur max-lobur merged commit f6fd67b into main Nov 23, 2023
4 checks passed
@max-lobur max-lobur deleted the spacelift-worker-docker branch November 23, 2023 12:40
mgledi pushed a commit to mfuhrmeisterDM/terraform-aws-components that referenced this pull request Nov 29, 2023
@milldr @mgledi
fix: spacelift/worker-pool AMI User Data Docker Login (cloudposse#913)
91e24a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hans-d hans-d hans-d approved these changes

@max-lobur max-lobur max-lobur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@milldr @hans-d @max-lobur