Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscriber input variable handler #44

Closed
wants to merge 1 commit into from
Closed

Fix subscriber input variable handler #44

wants to merge 1 commit into from

Conversation

ImperialOps
Copy link

what

Adds a valid key of type string for sns subscriber handler

why

A recent commit adds defaults to subscriber input but also breaks any input on map key type:
image

Proposed fix tested with following input, pulled from cloudposse/terraform-aws-sns-topic:

locals {
  subscribers = {
    opsgenie = {
      protocol = "https"
      endpoint = "https://api.example.com/v1/"
      endpoint_auto_confirms = true
    }
  }
}

module "test" {
  source = "../terraform-aws-config"
  # Cloud Posse recommends pinning every module to a specific version
  # version     = "x.x.x"

  create_sns_topic = true
  create_iam_role  = true

  subscribers = local.subscribers
}

thanks

Thank you for these modules! ❤

@snowsky
Copy link

snowsky commented Jun 15, 2023

James and I found this PR is valid. Could you please re-open the PR?

This was referenced Jun 19, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants